Don't let the authorization header be empty #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmck
reviewed
Oct 24, 2016
| @@ -177,7 +180,7 @@ export default class NpmRegistry extends Registry { | |||
| } | |||
| } | |||
|
|
|||
| return ''; | |||
| return undefined; | |||
There was a problem hiding this comment.
Make this return an empty string please, we should ensure types are monomorphic if we can. An empty string will still evaluate the branch added above.
There was a problem hiding this comment.
👍 My first change completely ignored flowtype and changed only this line. I didn't realize after having changed the code calling the method that the change there wasn't even necessary anymore.
It create problems with some servers like ProGet when used as a nuget cache. It's most likely the source of yarnpkg#825 and yarnpkg#1260
samccone
reviewed
Oct 24, 2016
| @@ -58,7 +58,10 @@ export default class NpmRegistry extends Registry { | |||
|
|
|||
| const headers = {}; | |||
| if (this.token || (alwaysAuth && requestUrl.startsWith(registry))) { | |||
| headers.authorization = this.getAuth(pathname); | |||
| const authorization = this.getAuth(pathname); | |||
There was a problem hiding this comment.
should we consider adding test coverage here via a unit test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is aimed at solving problems with
@types(And I guess other public scopes) that can be seen in #825 and #1260 where even with the latest version yarn fails to restore packages where npm succeed. The case is specific to enterprise caches as the yarn or npm default repositories aren't affected.In my case I had the problem and tested the resolution on ProGet ( http://inedo.com/proget ) configured with an NPM connector..
The issue is that
always-authis assumed for scoped packages, andalways-authforces the creation of anauthorization:http header, even when no authentication can be found. The header is created empty in this case. As ProGet is an ASP.Net application and this platform consider an empty authorization header to be something that can never be met, it refuses the connection.This PR doesn't change the behavior of
always-authbeing assumed for scoped packages but it remove the empty header if no authentication can be found.Test plan
yarnto restore packages in a previously non-working repository and checked that It worked, creating the lock file and was usable after. Testedyarn addwith a new packages in@typesI don't have access to a repository that require authentication for scoped packages but the change is minimal and doesn't affect any case where authentication was sent before so it shouldn't affect them (Also npm doesn't send the header in such cases)